Fix Gutenberg keyboard hide observer to handle dismissal notifications by Copilot · Pull Request #25544 · wordpress-mobile/WordPress-iOS

Copilot · 2026-05-08T08:07:32Z

This stacked PR addresses feedback from the SwiftLint follow-up thread by fixing a pre-existing observer wiring bug in GutenbergViewController. The hide observer was incorrectly subscribed to keyboard show notifications, preventing the hide path from running on keyboard dismissal.

Observer wiring
- Changed keyboardHideObserver to subscribe to UIResponder.keyboardDidHideNotification instead of UIResponder.keyboardDidShowNotification.
Behavioral impact
- Restores expected keyboard-dismiss handling so editor constraints can be updated when the keyboard hides.

keyboardHideObserver = NotificationCenter.default.addObserver(
    forName: UIResponder.keyboardDidHideNotification,
    object: nil,
    queue: .main
) { [weak self] notification in
    if let self, let keyboardRect = notification.userInfo?[UIResponder.keyboardFrameEndUserInfoKey] as? CGRect {
        self.keyboardFrame = keyboardRect
        self.updateConstraintsToAvoidKeyboard(frame: keyboardRect)
    }
}

dangermattic · 2026-05-08T08:08:05Z

	1 Message
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Agent-Logs-Url: https://github.com/wordpress-mobile/WordPress-iOS/sessions/7c35862b-6e7d-4fd5-adde-7d42afde9eaa Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com>

wpmobilebot · 2026-05-08T08:23:12Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`32179`
	Version	`PR #25544`
	Bundle ID	`com.jetpack.alpha`
	Commit	`0cf5b6f`
	Installation URL	746qmu4rk8qbg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-05-08T08:23:13Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`32179`
	Version	`PR #25544`
	Bundle ID	`org.wordpress.alpha`
	Commit	`0cf5b6f`
	Installation URL	7282e8kbjtpd8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

mokagio · 2026-05-08T09:24:30Z

            }
        }
-        keyboardHideObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardDidShowNotification, object: nil, queue: .main) { [weak self] notification in
+        keyboardHideObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardDidHideNotification, object: nil, queue: .main) { [weak self] notification in


@crazytonyli @jkmassel this makes sense to me: The hide observer should subscribe to the hide notification. But you'll sure have more context on the choices of implementation.

Copilot

Pull request overview

Fixes keyboard dismissal handling in the Gutenberg editor by correcting a miswired notification observer so constraint updates run when the keyboard actually hides.

Changes:

Updated keyboardHideObserver to subscribe to UIResponder.keyboardDidHideNotification (instead of keyboardDidShowNotification).
Restores the keyboard-dismiss path so updateConstraintsToAvoidKeyboard is invoked on dismissal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crazytonyli

Looks like a copy-pasta error.

…press-mobile#25521) * Enable SwiftLint rule: unneeded_parentheses_in_closure_argument Removes redundant parens around closure parameter lists. SwiftLint --fix produced 809 changes across 240 files. Part of the Orchard SwiftLint rollout campaign. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com> * Add space after capture list in two closures Follow-up to the previous commit's SwiftLint autocorrect. The `unneeded_parentheses_in_closure_argument` rule removed `(media, state)` parens but did not insert a space when the opening paren had been flush against `[weak self]`, leaving `[weak self]media, state in`. Restore the space for readability and style consistency. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com> * Fix Gutenberg keyboard hide observer to handle dismissal notifications (wordpress-mobile#25544) * Initial plan * Fix Gutenberg keyboard hide observer notification Agent-Logs-Url: https://github.com/wordpress-mobile/WordPress-iOS/sessions/7c35862b-6e7d-4fd5-adde-7d42afde9eaa Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com> --------- Co-authored-by: Claude Code Opus 4.7 <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com>

Initial plan

4e0983e

Copilot AI assigned Copilot and mokagio May 8, 2026

Copilot AI mentioned this pull request May 8, 2026

Enable SwiftLint rule: unneeded_parentheses_in_closure_argument #25521

Merged

2 tasks

Copilot started work on behalf of mokagio May 8, 2026 08:07 View session

Fix Gutenberg keyboard hide observer notification

0cf5b6f

Agent-Logs-Url: https://github.com/wordpress-mobile/WordPress-iOS/sessions/7c35862b-6e7d-4fd5-adde-7d42afde9eaa Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] [WIP] Address feedback on enabling SwiftLint rule: unneeded_parentheses_in_closure_argument~~ Fix Gutenberg keyboard hide observer to handle dismissal notifications May 8, 2026

Copilot finished work on behalf of mokagio May 8, 2026 08:10

Copilot AI requested a review from mokagio May 8, 2026 08:10

mokagio reviewed May 8, 2026

View reviewed changes

mokagio marked this pull request as ready for review May 8, 2026 09:24

Copilot AI review requested due to automatic review settings May 8, 2026 09:24

Copilot started reviewing on behalf of mokagio May 8, 2026 09:25 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

crazytonyli approved these changes May 8, 2026

View reviewed changes

crazytonyli merged commit 368e894 into mokagio/swiftlint-unneeded-parens-closure-arg May 8, 2026
28 checks passed

crazytonyli deleted the copilot/sub-pr-25521 branch May 8, 2026 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Gutenberg keyboard hide observer to handle dismissal notifications#25544

Fix Gutenberg keyboard hide observer to handle dismissal notifications#25544
crazytonyli merged 2 commits into
mokagio/swiftlint-unneeded-parens-closure-argfrom
copilot/sub-pr-25521

Copilot AI commented May 8, 2026 •

edited

Loading

Uh oh!

dangermattic commented May 8, 2026

Uh oh!

wpmobilebot commented May 8, 2026

Uh oh!

wpmobilebot commented May 8, 2026

Uh oh!

mokagio May 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

crazytonyli left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Copilot AI commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangermattic commented May 8, 2026

Uh oh!

wpmobilebot commented May 8, 2026

Uh oh!

wpmobilebot commented May 8, 2026

Uh oh!

mokagio May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

crazytonyli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented May 8, 2026 •

edited

Loading